<p>Marc Jones has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21998">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">amd/soc/common: Print and error if an AGESA callout isn't supported<br><br>Let the developer or user know that a callout isn't supported.<br><br>Change-Id: I73a6c6930a6661627ad76e27bbb78be99e237949<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>---<br>M src/soc/amd/common/def_callouts.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/21998/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c<br>index bad4f58..3e332ac 100644<br>--- a/src/soc/amd/common/def_callouts.c<br>+++ b/src/soc/amd/common/def_callouts.c<br>@@ -33,8 +33,12 @@<br>                if (BiosCallouts[i].CalloutName == Func)<br>                      break;<br>        }<br>-    if (i >= BiosCalloutsLen)<br>+<br>+      if (i >= BiosCalloutsLen) {<br>+               printk(BIOS_ERR, "ERROR: AGESA Callout Not Supported: 0x%x",<br>+                       (u32)Func);<br>           return AGESA_UNSUPPORTED;<br>+    }<br> <br>  return BiosCallouts[i].CalloutPtr(Func, Data, ConfigPtr);<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/21998">change 21998</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21998"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I73a6c6930a6661627ad76e27bbb78be99e237949 </div>
<div style="display:none"> Gerrit-Change-Number: 21998 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>