[coreboot-gerrit] Change in coreboot[master]: mainboard/pcengines/apu2: use GENERIC_SPD_BIN

[Kamil Wcisło (Code Review)]

Kamil Wcisło has uploaded this change for review. ( https://review.coreboot.org/21980


Change subject: mainboard/pcengines/apu2: use GENERIC_SPD_BIN
......................................................................

mainboard/pcengines/apu2: use GENERIC_SPD_BIN

Use GENERIC_SPD_BIN method of adding the SPD bins to final rom.

Change-Id: I242e393bafac41aa7743f83b52cadf027019ee6e
Signed-off-by: Kamil Wcislo <kamil.wcislo at 3mdeb.com>
---
M src/mainboard/pcengines/apu2/Kconfig
M src/mainboard/pcengines/apu2/Makefile.inc
R src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex
R src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex
4 files changed, 3 insertions(+), 18 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/21980/1

diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig
index a077520..cbcbb7c 100644
--- a/src/mainboard/pcengines/apu2/Kconfig
+++ b/src/mainboard/pcengines/apu2/Kconfig
@@ -29,6 +29,7 @@
 	select BOARD_ROMSIZE_KB_8192
 	select HUDSON_DISABLE_IMC
 	select USE_BLOBS
+	select GENERIC_SPD_BIN
 	select TPM
 	select MAINBOARD_HAS_LPC_TPM
 
diff --git a/src/mainboard/pcengines/apu2/Makefile.inc b/src/mainboard/pcengines/apu2/Makefile.inc
index 77c6d78..3724b17 100644
--- a/src/mainboard/pcengines/apu2/Makefile.inc
+++ b/src/mainboard/pcengines/apu2/Makefile.inc
@@ -21,22 +21,6 @@
 ramstage-y += OemCustomize.c
 ramstage-y += gpio_ftns.c
 
-## DIMM SPD for on-board memory
-SPD_BIN = $(obj)/spd.bin
-
 # Order of names in SPD_SOURCES is important!
-SPD_SOURCES  = HYNIX-2G-1333 HYNIX-4G-1333-ECC
-
-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.hex)
-
-# Include spd rom data
-$(SPD_BIN): $(SPD_DEPS)
-	for f in $+; \
-	  do for c in $$(cat $$f | grep -v ^#); \
-	    do printf $$(printf '\%o' 0x$$c); \
-	  done; \
-	done > $@
-
-cbfs-files-y += spd.bin
-spd.bin-file := $(SPD_BIN)
-spd.bin-type := spd
+SPD_SOURCES  = HYNIX-2G-1333
+SPD_SOURCES += HYNIX-4G-1333-ECC
diff --git a/src/mainboard/pcengines/apu2/HYNIX-2G-1333.spd.hex b/src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex
similarity index 100%
rename from src/mainboard/pcengines/apu2/HYNIX-2G-1333.spd.hex
rename to src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex
diff --git a/src/mainboard/pcengines/apu2/HYNIX-4G-1333-ECC.spd.hex b/src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex
similarity index 100%
rename from src/mainboard/pcengines/apu2/HYNIX-4G-1333-ECC.spd.hex
rename to src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex

-- 
To view, visit https://review.coreboot.org/21980
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I242e393bafac41aa7743f83b52cadf027019ee6e
Gerrit-Change-Number: 21980
Gerrit-PatchSet: 1
Gerrit-Owner: Kamil Wcisło <kamil.wcislo at 3mdeb.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171012/562f827c/attachment-0001.html>