<p>Kamil Wcisło has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21980">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/pcengines/apu2: use GENERIC_SPD_BIN<br><br>Use GENERIC_SPD_BIN method of adding the SPD bins to final rom.<br><br>Change-Id: I242e393bafac41aa7743f83b52cadf027019ee6e<br>Signed-off-by: Kamil Wcislo <kamil.wcislo@3mdeb.com><br>---<br>M src/mainboard/pcengines/apu2/Kconfig<br>M src/mainboard/pcengines/apu2/Makefile.inc<br>R src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex<br>R src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex<br>4 files changed, 3 insertions(+), 18 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/21980/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig<br>index a077520..cbcbb7c 100644<br>--- a/src/mainboard/pcengines/apu2/Kconfig<br>+++ b/src/mainboard/pcengines/apu2/Kconfig<br>@@ -29,6 +29,7 @@<br>      select BOARD_ROMSIZE_KB_8192<br>  select HUDSON_DISABLE_IMC<br>     select USE_BLOBS<br>+     select GENERIC_SPD_BIN<br>        select TPM<br>    select MAINBOARD_HAS_LPC_TPM<br> <br>diff --git a/src/mainboard/pcengines/apu2/Makefile.inc b/src/mainboard/pcengines/apu2/Makefile.inc<br>index 77c6d78..3724b17 100644<br>--- a/src/mainboard/pcengines/apu2/Makefile.inc<br>+++ b/src/mainboard/pcengines/apu2/Makefile.inc<br>@@ -21,22 +21,6 @@<br> ramstage-y += OemCustomize.c<br> ramstage-y += gpio_ftns.c<br> <br>-## DIMM SPD for on-board memory<br>-SPD_BIN = $(obj)/spd.bin<br>-<br> # Order of names in SPD_SOURCES is important!<br>-SPD_SOURCES  = HYNIX-2G-1333 HYNIX-4G-1333-ECC<br>-<br>-SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.hex)<br>-<br>-# Include spd rom data<br>-$(SPD_BIN): $(SPD_DEPS)<br>-      for f in $+; \<br>-         do for c in $$(cat $$f | grep -v ^#); \<br>-        do printf $$(printf '\%o' 0x$$c); \<br>-        done; \<br>-    done > $@<br>-<br>-cbfs-files-y += spd.bin<br>-spd.bin-file := $(SPD_BIN)<br>-spd.bin-type := spd<br>+SPD_SOURCES  = HYNIX-2G-1333<br>+SPD_SOURCES += HYNIX-4G-1333-ECC<br>diff --git a/src/mainboard/pcengines/apu2/HYNIX-2G-1333.spd.hex b/src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex<br>similarity index 100%<br>rename from src/mainboard/pcengines/apu2/HYNIX-2G-1333.spd.hex<br>rename to src/mainboard/pcengines/apu2/spd/HYNIX-2G-1333.spd.hex<br>diff --git a/src/mainboard/pcengines/apu2/HYNIX-4G-1333-ECC.spd.hex b/src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex<br>similarity index 100%<br>rename from src/mainboard/pcengines/apu2/HYNIX-4G-1333-ECC.spd.hex<br>rename to src/mainboard/pcengines/apu2/spd/HYNIX-4G-1333-ECC.spd.hex<br></pre><p>To view, visit <a href="https://review.coreboot.org/21980">change 21980</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21980"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I242e393bafac41aa7743f83b52cadf027019ee6e </div>
<div style="display:none"> Gerrit-Change-Number: 21980 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kamil Wcisło <kamil.wcislo@3mdeb.com> </div>