[coreboot-gerrit] Change in coreboot[master]: cpu/x86/mtrr: Optimize hole carving strategy

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21915 )

Change subject: cpu/x86/mtrr: Optimize hole carving strategy
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/21915/4/src/cpu/x86/mtrr/mtrr.c
File src/cpu/x86/mtrr/mtrr.c:

https://review.coreboot.org/#/c/21915/4/src/cpu/x86/mtrr/mtrr.c@607
PS4, Line 607: 		return;
Sigh, I did concentrate too much on the other paths below and didn't
optimize this one. In case we wouldn't have to align up at all, a1..a2
would be an equal or better solution.

e.g.

       a1       a2
    0b01010..0b01011 1 MTRR

but aligned to the next power of 2

    0b01010..0b10000 2 MTRRs



-- 
To view, visit https://review.coreboot.org/21915
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefb064ce8c4f293490a19dd46054b966c63bde44
Gerrit-Change-Number: 21915
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 09 Oct 2017 12:26:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171009/8f1ded14/attachment.html>