<p>Nico Huber <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21915">View Change</a></p><p>Patch set 4:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21915/4/src/cpu/x86/mtrr/mtrr.c">File src/cpu/x86/mtrr/mtrr.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21915/4/src/cpu/x86/mtrr/mtrr.c@607">Patch Set #4, Line 607:</a> <code style="font-family:monospace,monospace">            return;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Sigh, I did concentrate too much on the other paths below and didn't<br>optimize this one. In case we wouldn't have to align up at all, a1..a2<br>would be an equal or better solution.</p><p style="white-space: pre-wrap; word-wrap: break-word;">e.g.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       a1       a2<br>    0b01010..0b01011 1 MTRR</pre><p style="white-space: pre-wrap; word-wrap: break-word;">but aligned to the next power of 2</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    0b01010..0b10000 2 MTRRs</pre></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21915">change 21915</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21915"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iefb064ce8c4f293490a19dd46054b966c63bde44 </div>
<div style="display:none"> Gerrit-Change-Number: 21915 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 09 Oct 2017 12:26:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>