[coreboot-gerrit] Change in coreboot[master]: src/soc/skylake: Fix Null pointer dereferences

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/21909 )

Change subject: src/soc/skylake: Fix Null pointer dereferences
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/21909/1/src/soc/intel/skylake/pmutil.c
File src/soc/intel/skylake/pmutil.c:

https://review.coreboot.org/#/c/21909/1/src/soc/intel/skylake/pmutil.c@213
PS1, Line 213:  = NULL
Why do you need to initialize this?


https://review.coreboot.org/#/c/21909/1/src/soc/intel/skylake/pmutil.c@223
PS1, Line 223: if(config != NULL)
Why do you need this check if you return above when dev->chip_info is NULL.



-- 
To view, visit https://review.coreboot.org/21909
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec7a88a03531bbfeb72cedab5ad93d3a4c23eef5
Gerrit-Change-Number: 21909
Gerrit-PatchSet: 1
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Comment-Date: Fri, 06 Oct 2017 19:56:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171006/0f839237/attachment.html>