<p>Furquan Shaikh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21909">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21909/1/src/soc/intel/skylake/pmutil.c">File src/soc/intel/skylake/pmutil.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21909/1/src/soc/intel/skylake/pmutil.c@213">Patch Set #1, Line 213:</a> <code style="font-family:monospace,monospace"> = NULL</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why do you need to initialize this?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21909/1/src/soc/intel/skylake/pmutil.c@223">Patch Set #1, Line 223:</a> <code style="font-family:monospace,monospace">if(config != NULL)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why do you need this check if you return above when dev->chip_info is NULL.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21909">change 21909</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21909"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iec7a88a03531bbfeb72cedab5ad93d3a4c23eef5 </div>
<div style="display:none"> Gerrit-Change-Number: 21909 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shaunak Saha <shaunak.saha@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 06 Oct 2017 19:56:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>