[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable bus master for sata

Kane Chen (Code Review) gerrit at coreboot.org
Thu Oct 5 05:03:34 CEST 2017


Kane Chen has uploaded this change for review. ( https://review.coreboot.org/21890


Change subject: soc/intel/skylake: Enable bus master for sata
......................................................................

soc/intel/skylake: Enable bus master for sata

The bus master needs to be enabled so that
the busy bit will be clear by controller
when depthcharge tries to wait for sata
to complete spin-up during ahci init.
Otherwise, the timeout will happen and cause
5 seconds delay in depthcharge

Change-Id: I19eadbb2943fda8a5babc82ca87b1ecaab5e2ed8
Signed-off-by: Kane Chen <kane.chen at intel.com>
---
M src/soc/intel/common/block/sata/sata.c
1 file changed, 5 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/21890/1

diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c
index 5cacc95..f300656 100644
--- a/src/soc/intel/common/block/sata/sata.c
+++ b/src/soc/intel/common/block/sata/sata.c
@@ -45,6 +45,11 @@
 	u32 port_impl, temp;
 
 	dev = PCH_DEV_SATA;
+
+	/* Set Bus Master */
+	temp = pci_read_config32(dev, PCI_COMMAND);
+	pci_write_config32(dev, PCI_COMMAND, temp | PCI_COMMAND_MASTER);
+
 	/* Read Ports Implemented (GHC_PI) */
 	port_impl = read32(ahcibar + SATA_ABAR_PORT_IMPLEMENTED) & 0x07;
 	/* Port enable */

-- 
To view, visit https://review.coreboot.org/21890
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19eadbb2943fda8a5babc82ca87b1ecaab5e2ed8
Gerrit-Change-Number: 21890
Gerrit-PatchSet: 1
Gerrit-Owner: Kane Chen <kane.chen at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171005/a56da3fb/attachment.html>


More information about the coreboot-gerrit mailing list