[coreboot-gerrit] Change in coreboot[master]: [TEST]drivers/net/r8168: Add customized nic led function

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21839 )

Change subject: [TEST]drivers/net/r8168: Add customized nic led function
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c
File src/drivers/net/r8168.c:

https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224
PS2, Line 224: #if
better avoid preprocessor and just do "if (!IS_ENABLED(...)) return;"


https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224
PS2, Line 224: defined
IS_ENABED


https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@231
PS2, Line 231: CONFIG_RTL8168_CUSTOMIZED_LED
please use devicetree parameters instead of Kconfig.



-- 
To view, visit https://review.coreboot.org/21839
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9
Gerrit-Change-Number: 21839
Gerrit-PatchSet: 2
Gerrit-Owner: Wisley Chen <wisley.chen at quantatw.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: T.H. Lin <T.H_Lin at quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 02 Oct 2017 08:25:59 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171002/d26acf52/attachment.html>