<p>Arthur Heymans <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21839">View Change</a></p><p>Patch set 2:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c">File src/drivers/net/r8168.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224">Patch Set #2, Line 224:</a> <code style="font-family:monospace,monospace">#if</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">better avoid preprocessor and just do "if (!IS_ENABLED(...)) return;"</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224">Patch Set #2, Line 224:</a> <code style="font-family:monospace,monospace">defined</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">IS_ENABED</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@231">Patch Set #2, Line 231:</a> <code style="font-family:monospace,monospace">CONFIG_RTL8168_CUSTOMIZED_LED</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please use devicetree parameters instead of Kconfig.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21839">change 21839</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21839"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I9d2a5ad15dd7160afedb316493481490183222f9 </div>
<div style="display:none"> Gerrit-Change-Number: 21839 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Wisley Chen <wisley.chen@quantatw.com> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: T.H. Lin <T.H_Lin@quantatw.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 02 Oct 2017 08:25:59 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>