[coreboot-gerrit] Change in coreboot[master]: src/mainboard/glkrvp: Enable Touchpad

[Shaunak Saha (Code Review)]

Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/22627


Change subject: src/mainboard/glkrvp: Enable Touchpad
......................................................................

src/mainboard/glkrvp: Enable Touchpad

This patch enables the APLS touchpad in glkrvp platform.

TEST= Boot and test touchpad works.

Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f
Signed-off-by: Shaunak Saha <shaunak.saha at intel.com>
---
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/glkrvp/dsdt.asl
M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
3 files changed, 11 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/22627/1

diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig
index 56ab00b..dfb53b8 100644
--- a/src/mainboard/intel/glkrvp/Kconfig
+++ b/src/mainboard/intel/glkrvp/Kconfig
@@ -4,13 +4,13 @@
 	select SOC_INTEL_GLK
 	select BOARD_ROMSIZE_KB_16384
 	select DRIVERS_I2C_GENERIC
+	select DRIVERS_I2C_HID
 	select DRIVERS_PS2_KEYBOARD
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select MAINBOARD_HAS_CHROMEOS
 	select MAINBOARD_HAS_LPC_TPM
 	select MAINBOARD_HAS_TPM2
-	select DRIVERS_I2C_GENERIC
 	select DRIVERS_GENERIC_MAX98357A
 	select DRIVERS_I2C_DA7219
 
diff --git a/src/mainboard/intel/glkrvp/dsdt.asl b/src/mainboard/intel/glkrvp/dsdt.asl
index 9dee22a..3a80f6c 100644
--- a/src/mainboard/intel/glkrvp/dsdt.asl
+++ b/src/mainboard/intel/glkrvp/dsdt.asl
@@ -14,8 +14,7 @@
  */
 
 #include <variant/ec.h>
-#define GPE_EC_WAKE	0x26
-#define EC_SCI_GPI	GPE0_DW1_05
+#include <variant/gpio.h>
 
 DefinitionBlock(
 	"dsdt.aml",
@@ -66,6 +65,4 @@
 		/* Include common dptf ASL files */
 		#include <soc/intel/common/acpi/dptf/dptf.asl>
 	}
-	#include "touchpad.asl"
-	#include "touchpanel.asl"
 }
diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
index 4b93947..c083145 100644
--- a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
+++ b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb
@@ -143,7 +143,15 @@
 		device pci 16.1 off end	# - I2C 1
 		device pci 16.2 off end # - I2C 2
 		device pci 16.3 off end # - I2C 3
-		device pci 17.0 on  end # - I2C 4
+		device pci 17.0 on
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ALPS0001""
+				register "generic.desc" = ""Touchpad""
+				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
+				register "hid_desc_reg_offset" = "0x1"
+				device i2c 2C on end
+			end
+		end # I2C 4
 		device pci 17.1 off end	# - I2C 5
 		device pci 17.2 off end	# - I2C 6
 		device pci 17.3 on  end # - I2C 7

-- 
To view, visit https://review.coreboot.org/22627
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f
Gerrit-Change-Number: 22627
Gerrit-PatchSet: 1
Gerrit-Owner: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: AndreX Andraos <andrex.andraos at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171130/7d1df2c2/attachment-0001.html>