<p>Shaunak Saha has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22627">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">src/mainboard/glkrvp: Enable Touchpad<br><br>This patch enables the APLS touchpad in glkrvp platform.<br><br>TEST= Boot and test touchpad works.<br><br>Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f<br>Signed-off-by: Shaunak Saha <shaunak.saha@intel.com><br>---<br>M src/mainboard/intel/glkrvp/Kconfig<br>M src/mainboard/intel/glkrvp/dsdt.asl<br>M src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb<br>3 files changed, 11 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/22627/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig<br>index 56ab00b..dfb53b8 100644<br>--- a/src/mainboard/intel/glkrvp/Kconfig<br>+++ b/src/mainboard/intel/glkrvp/Kconfig<br>@@ -4,13 +4,13 @@<br>        select SOC_INTEL_GLK<br>  select BOARD_ROMSIZE_KB_16384<br>         select DRIVERS_I2C_GENERIC<br>+   select DRIVERS_I2C_HID<br>        select DRIVERS_PS2_KEYBOARD<br>   select HAVE_ACPI_RESUME<br>       select HAVE_ACPI_TABLES<br>       select MAINBOARD_HAS_CHROMEOS<br>         select MAINBOARD_HAS_LPC_TPM<br>  select MAINBOARD_HAS_TPM2<br>-    select DRIVERS_I2C_GENERIC<br>    select DRIVERS_GENERIC_MAX98357A<br>      select DRIVERS_I2C_DA7219<br> <br>diff --git a/src/mainboard/intel/glkrvp/dsdt.asl b/src/mainboard/intel/glkrvp/dsdt.asl<br>index 9dee22a..3a80f6c 100644<br>--- a/src/mainboard/intel/glkrvp/dsdt.asl<br>+++ b/src/mainboard/intel/glkrvp/dsdt.asl<br>@@ -14,8 +14,7 @@<br>  */<br> <br> #include <variant/ec.h><br>-#define GPE_EC_WAKE     0x26<br>-#define EC_SCI_GPI       GPE0_DW1_05<br>+#include <variant/gpio.h><br> <br> DefinitionBlock(<br>   "dsdt.aml",<br>@@ -66,6 +65,4 @@<br>              /* Include common dptf ASL files */<br>           #include <soc/intel/common/acpi/dptf/dptf.asl><br>  }<br>-    #include "touchpad.asl"<br>-    #include "touchpanel.asl"<br> }<br>diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb<br>index 4b93947..c083145 100644<br>--- a/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb<br>+++ b/src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb<br>@@ -143,7 +143,15 @@<br>            device pci 16.1 off end # - I2C 1<br>             device pci 16.2 off end # - I2C 2<br>             device pci 16.3 off end # - I2C 3<br>-            device pci 17.0 on  end # - I2C 4<br>+            device pci 17.0 on<br>+                   chip drivers/i2c/hid<br>+                         register "generic.hid" = ""ALPS0001""<br>+                          register "generic.desc" = ""Touchpad""<br>+                         register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"<br>+                               register "hid_desc_reg_offset" = "0x1"<br>+                           device i2c 2C on end<br>+                 end<br>+          end # I2C 4<br>           device pci 17.1 off end # - I2C 5<br>             device pci 17.2 off end # - I2C 6<br>             device pci 17.3 on  end # - I2C 7<br></pre><p>To view, visit <a href="https://review.coreboot.org/22627">change 22627</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22627"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6f52f7db57ab52b5531e647bde2adbb78b40f76f </div>
<div style="display:none"> Gerrit-Change-Number: 22627 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Shaunak Saha <shaunak.saha@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: AndreX Andraos <andrex.andraos@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Hannah Williams <hannah.williams@intel.com> </div>