[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge/include/soc/northbridge.h: Cleanup

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22635 )

Change subject: amd/stoneyridge/include/soc/northbridge.h: Cleanup
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/22635/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@9
PS1, Line 9: There are instances where the pound "#" is separated from the word "define",
           : it should be all together "#define".
> Why?  This is a common convention throughout the codebase to show that this
I was not aware of this convention. I can undo it.


https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@12
PS1, Line 12: There are instances where bits are being declared as (1 << x), should be
            : replaced by macro BIT(x).
> Again, the (1 << x) is very common throughout the coreboot codebase.  What'
Earlier (about 2 month ago) I was requested to do that with southbridge.h. Otherwise I would not have changed it.


https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@15
PS1, Line 15: 62239898
> 62239898 - Kahlee: coreboot - stoneyridge - include headers for filetypes u
As I mentioned in bugganizer, all that was requested was already done, and I had only seen these as possible clean up before marking the issue as fixed. If I should revert my changes, then I should probably abandon this review and close the issue (mark as fixed).



-- 
To view, visit https://review.coreboot.org/22635
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I882bf1cc9d9e6b587b5dc3d27cea1626f4dcc51a
Gerrit-Change-Number: 22635
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:06:58 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171130/cd3d8c63/attachment.html>