[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge/include/soc/northbridge.h: Cleanup

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22635 )

Change subject: amd/stoneyridge/include/soc/northbridge.h: Cleanup
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

I'd rather that none of these changes were made.

https://review.coreboot.org/#/c/22635/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@9
PS1, Line 9: There are instances where the pound "#" is separated from the word "define",
           : it should be all together "#define".
Why?  This is a common convention throughout the codebase to show that this #define is a part of the previous register.

This extra space helps visually to separate the register number from the register components.


https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@12
PS1, Line 12: There are instances where bits are being declared as (1 << x), should be
            : replaced by macro BIT(x).
Again, the (1 << x) is very common throughout the coreboot codebase.  What's the reason to change it in this file?  If it were mixed, I could see it all getting converted one way or the other, but why change it here?


https://review.coreboot.org/#/c/22635/1//COMMIT_MSG@15
PS1, Line 15: 62239898
62239898 - Kahlee: coreboot - stoneyridge - include headers for filetypes used.

What does this change have to do with this bug?


https://review.coreboot.org/#/c/22635/1/src/soc/amd/stoneyridge/include/soc/northbridge.h
File src/soc/amd/stoneyridge/include/soc/northbridge.h:

https://review.coreboot.org/#/c/22635/1/src/soc/amd/stoneyridge/include/soc/northbridge.h@59
PS1, Line 59: 	BIT(0)
No longer aligned after removing the space.



-- 
To view, visit https://review.coreboot.org/22635
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I882bf1cc9d9e6b587b5dc3d27cea1626f4dcc51a
Gerrit-Change-Number: 22635
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 22:20:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171129/d1587098/attachment.html>