[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Make use of Intel common Graphics block

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/22616 )

Change subject: soc/intel/apollolake: Make use of Intel common Graphics block
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c
File src/soc/intel/apollolake/graphics.c:

https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@a93
PS1, Line 93: 
Do you not need an init function which calls into pci_dev_init?


https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@28
PS1, Line 28: return
This function doesn't check for dev->enabled any more. Is that intentional?


https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@45
PS1, Line 45: /* TODO Initialize Mailbox 3 */
Does this TODO needs to be resolved?


https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@62
PS1, Line 62: /*
            : 	* TODO This needs to happen in S3 resume, too.
            : 	* Maybe it should move to the finalize handler.
            : 	*/
Does this TODO needs to be resolved?



-- 
To view, visit https://review.coreboot.org/22616
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0edd7454912201598c43e35990e470ec18a32638
Gerrit-Change-Number: 22616
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 20:58:37 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171128/1184e7ca/attachment.html>