<p>Furquan Shaikh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22616">View Change</a></p><p>Patch set 1:</p><p>(4 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c">File src/soc/intel/apollolake/graphics.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@a93">Patch Set #1, Line 93:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do you not need an init function which calls into pci_dev_init?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@28">Patch Set #1, Line 28:</a> <code style="font-family:monospace,monospace">return</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This function doesn't check for dev->enabled any more. Is that intentional?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@45">Patch Set #1, Line 45:</a> <code style="font-family:monospace,monospace">/* TODO Initialize Mailbox 3 */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does this TODO needs to be resolved?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22616/1/src/soc/intel/apollolake/graphics.c@62">Patch Set #1, Line 62:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/*<br>       * TODO This needs to happen in S3 resume, too.<br>        * Maybe it should move to the finalize handler.<br>       */<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Does this TODO needs to be resolved?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22616">change 22616</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22616"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I0edd7454912201598c43e35990e470ec18a32638 </div>
<div style="display:none"> Gerrit-Change-Number: 22616 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 28 Nov 2017 20:58:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>