[coreboot-gerrit] Change in coreboot[master]: lib/spd_bin: Only build when CONFIG option is set

[Marc Jones (Code Review)]

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/22575


Change subject: lib/spd_bin: Only build when CONFIG option is set
......................................................................

lib/spd_bin: Only build when CONFIG option is set

Only build spd_bin.c when GENERIC_SPD_BIN is selected. This issue
was found by Coverity scan, which fails 10 test when the dependent
MAX_DIMMS KCONFIG option is not built.

BUG=b:69669995
TEST=Build test.

Change-Id: I97a4d810199c96912d13737046e6041b74315164
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/lib/Makefile.inc
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/22575/1

diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc
index 25537d2..a041b32 100644
--- a/src/lib/Makefile.inc
+++ b/src/lib/Makefile.inc
@@ -309,9 +309,10 @@
 
 endif # CONFIG_RAMSTAGE_LIBHWBASE
 
-romstage-y += spd_bin.c
 
 ifeq ($(CONFIG_GENERIC_SPD_BIN),y)
+romstage-y += spd_bin.c
+
 LIB_SPD_BIN = $(obj)/spd.bin
 
 LIB_SPD_DEPS = $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)

-- 
To view, visit https://review.coreboot.org/22575
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97a4d810199c96912d13737046e6041b74315164
Gerrit-Change-Number: 22575
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171123/a4afa872/attachment.html>