<p>Marc Jones has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22575">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lib/spd_bin: Only build when CONFIG option is set<br><br>Only build spd_bin.c when GENERIC_SPD_BIN is selected. This issue<br>was found by Coverity scan, which fails 10 test when the dependent<br>MAX_DIMMS KCONFIG option is not built.<br><br>BUG=b:69669995<br>TEST=Build test.<br><br>Change-Id: I97a4d810199c96912d13737046e6041b74315164<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>---<br>M src/lib/Makefile.inc<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/22575/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc<br>index 25537d2..a041b32 100644<br>--- a/src/lib/Makefile.inc<br>+++ b/src/lib/Makefile.inc<br>@@ -309,9 +309,10 @@<br> <br> endif # CONFIG_RAMSTAGE_LIBHWBASE<br> <br>-romstage-y += spd_bin.c<br> <br> ifeq ($(CONFIG_GENERIC_SPD_BIN),y)<br>+romstage-y += spd_bin.c<br>+<br> LIB_SPD_BIN = $(obj)/spd.bin<br> <br> LIB_SPD_DEPS = $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)<br></pre><p>To view, visit <a href="https://review.coreboot.org/22575">change 22575</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22575"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I97a4d810199c96912d13737046e6041b74315164 </div>
<div style="display:none"> Gerrit-Change-Number: 22575 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>