[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to ...

[John Zhao (Code Review)]

Hello John Zhao,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/22549

to review the following change.


Change subject: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to reset
......................................................................

soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to reset

If CSE failes to do a global reset with the calling sequence of heci
reset/send/receive, then invoke pmc and hard reset.

TEST= Force global reset from early or late romstage. It is observed timed
out error occuring with heci_receive only during early romstage.

Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787
Signed-off-by: John Zhao <john.zhao at intel.com>
---
M src/soc/intel/cannonlake/reset.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/22549/1

diff --git a/src/soc/intel/cannonlake/reset.c b/src/soc/intel/cannonlake/reset.c
index a270a56..7eb8929 100644
--- a/src/soc/intel/cannonlake/reset.c
+++ b/src/soc/intel/cannonlake/reset.c
@@ -80,7 +80,9 @@
 void do_global_reset(void)
 {
 	/* Ask CSE to do the global reset */
-	send_heci_reset_message();
+	if(!send_heci_reset_message())
+		return;
+
 	/* global reset if CSE fail to reset */
 	pmc_global_reset_enable(1);
 	hard_reset();

-- 
To view, visit https://review.coreboot.org/22549
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787
Gerrit-Change-Number: 22549
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao at intel.corp-partner.google.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171121/9e8a0b92/attachment-0001.html>