<p>John Zhao would like John Zhao to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/22549">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to reset<br><br>If CSE failes to do a global reset with the calling sequence of heci<br>reset/send/receive, then invoke pmc and hard reset.<br><br>TEST= Force global reset from early or late romstage. It is observed timed<br>out error occuring with heci_receive only during early romstage.<br><br>Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787<br>Signed-off-by: John Zhao <john.zhao@intel.com><br>---<br>M src/soc/intel/cannonlake/reset.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/22549/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/cannonlake/reset.c b/src/soc/intel/cannonlake/reset.c<br>index a270a56..7eb8929 100644<br>--- a/src/soc/intel/cannonlake/reset.c<br>+++ b/src/soc/intel/cannonlake/reset.c<br>@@ -80,7 +80,9 @@<br> void do_global_reset(void)<br> {<br>     /* Ask CSE to do the global reset */<br>- send_heci_reset_message();<br>+   if(!send_heci_reset_message())<br>+               return;<br>+<br>    /* global reset if CSE fail to reset */<br>       pmc_global_reset_enable(1);<br>   hard_reset();<br></pre><p>To view, visit <a href="https://review.coreboot.org/22549">change 22549</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22549"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5bb12554e5745d7704a1b684a3a51034bb35f787 </div>
<div style="display:none"> Gerrit-Change-Number: 22549 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John Zhao <john.zhao@intel.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: John Zhao <john.zhao@intel.com> </div>