[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: add acoustic noise mitigation params for FSP 1.1

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/22524


Change subject: soc/intel/skylake: add acoustic noise mitigation params for FSP 1.1
......................................................................

soc/intel/skylake: add acoustic noise mitigation params for FSP 1.1

Adapted from Chromium commit d6655eb
[Skylake: create UPD Interface for acoustic noise tuning]

Add FSP 1.1 params needed for acoustic mitigation on google/caroline
(to be upstreamed in a subsequent commit).

TEST: build/boot google/caroline

Change-Id: Ifb36ecef8c1735c63a5322d952929e9c34cddfb9
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/soc/intel/skylake/chip.c
M src/soc/intel/skylake/chip.h
M src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
3 files changed, 48 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/22524/1

diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c
index dfa813a..f5596d2 100644
--- a/src/soc/intel/skylake/chip.c
+++ b/src/soc/intel/skylake/chip.c
@@ -203,6 +203,13 @@
 
 	params->SendVrMbxCmd = config->SendVrMbxCmd;
 
+	/* Acoustic Noise Mitigation */
+	params->AcousticNoiseMitigation = config->AcousticNoiseMitigation;
+	params->SlowSlewRateForIa = config->SlowSlewRateForIa;
+	params->SlowSlewRateForGt = config->SlowSlewRateForGt;
+	params->SlowSlewRateForSa = config->SlowSlewRateForSa;
+	params->FastPkgCRampDisable = config->FastPkgCRampDisable;
+
 	soc_irq_settings(params);
 }
 
@@ -808,6 +815,21 @@
 	fsp_display_upd_value("SendVrMbxCmd", 1,
 		original->SendVrMbxCmd,
 		params->SendVrMbxCmd);
+	fsp_display_upd_value("AcousticNoiseMitigation", 1,
+		original->AcousticNoiseMitigation,
+		params->AcousticNoiseMitigation);
+	fsp_display_upd_value("SlowSlewRateForIa", 1,
+		original->SlowSlewRateForIa,
+		params->SlowSlewRateForIa);
+	fsp_display_upd_value("SlowSlewRateForGt", 1,
+		original->SlowSlewRateForGt,
+		params->SlowSlewRateForGt);
+	fsp_display_upd_value("SlowSlewRateForSa", 1,
+		original->SlowSlewRateForSa,
+		params->SlowSlewRateForSa);
+	fsp_display_upd_value("FastPkgCRampDisable", 1,
+		original->FastPkgCRampDisable,
+		params->FastPkgCRampDisable);
 }
 
 static void pci_set_subsystem(device_t dev, unsigned int vendor,
diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index 2c282bc..fef4a7f 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -485,6 +485,9 @@
 	 * 0b - Enabled
 	 * 1b - Disabled
 	 */
+	/* FSP 1.1 */
+	u8 FastPkgCRampDisable;
+	/* FSP 2.0 */
 	u8 FastPkgCRampDisableIa;
 	u8 FastPkgCRampDisableGt;
 	u8 FastPkgCRampDisableSa;
diff --git a/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h b/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
index 45f2099..32b926a 100644
--- a/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
+++ b/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
@@ -1,6 +1,6 @@
 /** @file
 
-Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
 
 Redistribution and use in source and binary forms, with or without modification,
 are permitted provided that the following conditions are met:
@@ -950,14 +950,34 @@
   UINT8                       Early8254ClockGatingEnable;
 
 /** Offset 0x03E5 - Enable VR specific mailbox command
-  When set, an extra VR mailbox command specifically for the MPS IMPV8 VR will be sent. This for FSP only. 0 - Don't Send, 1 - Send
+  VR specific mailbox commands, 000b: no VR specific command sent, 001b: A VR mailbox command specifically for the MPS IMPV8 VR will be sent, 010b: VR specific command sent for PS4 exit issue, 011b: VR specific command sent for both MPS IMPV8 & PS4 exit issue.
   $EN_DIS
 **/
   UINT8                       SendVrMbxCmd;
 
 /** Offset 0x03E6
 **/
-  UINT8                       ReservedSiliconInitUpd[20];
+  UINT8                       AcousticNoiseMitigation;
+
+/** Offset 0x03E7
+**/
+  UINT8                       SlowSlewRateForIa;
+
+/** Offset 0x03E8
+**/
+  UINT8                       SlowSlewRateForGt;
+
+/** Offset 0x03E9
+**/
+  UINT8                       SlowSlewRateForSa;
+
+/** Offset 0x03EA
+**/
+  UINT8                       FastPkgCRampDisable;
+
+/** Offset 0x03EB
+**/
+  UINT8                       ReservedSiliconInitUpd[15];
 } SILICON_INIT_UPD;
 
 #define FSP_UPD_SIGNATURE                0x244450554C4B5324        /* '$SKLUPD$' */

-- 
To view, visit https://review.coreboot.org/22524
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb36ecef8c1735c63a5322d952929e9c34cddfb9
Gerrit-Change-Number: 22524
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171119/bdcc6a81/attachment-0001.html>