[coreboot-gerrit] Change in coreboot[master]: intel/common: Add error print in common i2c

[Lijian Zhao (Code Review)]

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/22405


Change subject: intel/common: Add error print in common i2c
......................................................................

intel/common: Add error print in common i2c

Print error message when using common i2c without default clock defined.

TEST=Do not define default clock in Kconfig, during boot time can see
the error message.

Change-Id: I803f97698b3928e6b64df0010e71a6ded1400f87
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/soc/intel/common/block/i2c/lpss_i2c.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/22405/1

diff --git a/src/soc/intel/common/block/i2c/lpss_i2c.c b/src/soc/intel/common/block/i2c/lpss_i2c.c
index 7db3fe9..e6e82b8 100644
--- a/src/soc/intel/common/block/i2c/lpss_i2c.c
+++ b/src/soc/intel/common/block/i2c/lpss_i2c.c
@@ -541,8 +541,10 @@
 	int i;
 
 	/* Clock must be provided by Kconfig */
-	if (!ic_clk)
+	if (!ic_clk) {
+		printk(BIOS_ERROR, "SOC must provide lpss clk in Kconfig.\n");
 		return -1;
+	}
 
 	/* Apply board specific override for this speed if found */
 	for (i = 0; i < LPSS_I2C_SPEED_CONFIG_COUNT; i++) {

-- 
To view, visit https://review.coreboot.org/22405
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I803f97698b3928e6b64df0010e71a6ded1400f87
Gerrit-Change-Number: 22405
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171109/c8f1f27a/attachment.html>