<p>Lijian Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22405">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">intel/common: Add error print in common i2c<br><br>Print error message when using common i2c without default clock defined.<br><br>TEST=Do not define default clock in Kconfig, during boot time can see<br>the error message.<br><br>Change-Id: I803f97698b3928e6b64df0010e71a6ded1400f87<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>---<br>M src/soc/intel/common/block/i2c/lpss_i2c.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/22405/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/common/block/i2c/lpss_i2c.c b/src/soc/intel/common/block/i2c/lpss_i2c.c<br>index 7db3fe9..e6e82b8 100644<br>--- a/src/soc/intel/common/block/i2c/lpss_i2c.c<br>+++ b/src/soc/intel/common/block/i2c/lpss_i2c.c<br>@@ -541,8 +541,10 @@<br>  int i;<br> <br>     /* Clock must be provided by Kconfig */<br>-      if (!ic_clk)<br>+ if (!ic_clk) {<br>+               printk(BIOS_ERROR, "SOC must provide lpss clk in Kconfig.\n");<br>              return -1;<br>+   }<br> <br>  /* Apply board specific override for this speed if found */<br>   for (i = 0; i < LPSS_I2C_SPEED_CONFIG_COUNT; i++) {<br></pre><p>To view, visit <a href="https://review.coreboot.org/22405">change 22405</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22405"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I803f97698b3928e6b64df0010e71a6ded1400f87 </div>
<div style="display:none"> Gerrit-Change-Number: 22405 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>