[coreboot-gerrit] Change in coreboot[master]: google/slippy: add board-specific USB port info
Martin Roth (Code Review)
gerrit at coreboot.org
Wed May 31 19:11:16 CEST 2017
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/19967 )
Change subject: google/slippy: add board-specific USB port info
......................................................................
google/slippy: add board-specific USB port info
Add capability and location data for USB ports/devices via
_PLD and _UPC ACPI methods, which is utilized by Windows and
required by macOS.
Each slippy variant has slightly different USB port config;
data for falco and leon to be added once available
Change-Id: Icc3b5b1161f62ac0b840380679acafeff363cf45
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
Reviewed-on: https://review.coreboot.org/19967
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/slippy/acpi/mainboard.asl
A src/mainboard/google/slippy/variants/falco/include/variant/acpi/usb.asl
A src/mainboard/google/slippy/variants/leon/include/variant/acpi/usb.asl
A src/mainboard/google/slippy/variants/peppy/include/variant/acpi/usb.asl
A src/mainboard/google/slippy/variants/wolf/include/variant/acpi/usb.asl
5 files changed, 249 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/slippy/acpi/mainboard.asl b/src/mainboard/google/slippy/acpi/mainboard.asl
index 7605e9e..f12a440 100644
--- a/src/mainboard/google/slippy/acpi/mainboard.asl
+++ b/src/mainboard/google/slippy/acpi/mainboard.asl
@@ -23,3 +23,6 @@
}
#include <variant/acpi/mainboard.asl>
+
+/* USB port entries */
+#include <variant/acpi/usb.asl>
diff --git a/src/mainboard/google/slippy/variants/falco/include/variant/acpi/usb.asl b/src/mainboard/google/slippy/variants/falco/include/variant/acpi/usb.asl
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/src/mainboard/google/slippy/variants/falco/include/variant/acpi/usb.asl
diff --git a/src/mainboard/google/slippy/variants/leon/include/variant/acpi/usb.asl b/src/mainboard/google/slippy/variants/leon/include/variant/acpi/usb.asl
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/src/mainboard/google/slippy/variants/leon/include/variant/acpi/usb.asl
diff --git a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/usb.asl b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/usb.asl
new file mode 100644
index 0000000..9227680
--- /dev/null
+++ b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/usb.asl
@@ -0,0 +1,126 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+Scope (\_SB.PCI0.XHCI.HUB7.PRT1)
+{
+ // WWAN M.2 Slot
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0xFF, // OEM Connector
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Not Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (Zero))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT2)
+{
+ // Left USB 2.0
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ Zero, // USB Port
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (One))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT3)
+{
+ // Webcam
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0xFF, // OEM Connector
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Not Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (Zero))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT4)
+{
+ // Bluetooth
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0xFF, // OEM Connector
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Not Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (Zero))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT5)
+{
+ // Right USB 2.0
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ Zero, // USB Port
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (One))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT7)
+{
+ // SD Card
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0xFF, // OEM Connector
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Not Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (Zero))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.SSP1)
+{
+ // Left USB 3.0
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0x03, // USB 3.0 Port
+ Zero, // Reserved
+ Zero // Reserved
+ })
+}
diff --git a/src/mainboard/google/slippy/variants/wolf/include/variant/acpi/usb.asl b/src/mainboard/google/slippy/variants/wolf/include/variant/acpi/usb.asl
new file mode 100644
index 0000000..1799640
--- /dev/null
+++ b/src/mainboard/google/slippy/variants/wolf/include/variant/acpi/usb.asl
@@ -0,0 +1,120 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+Scope (\_SB.PCI0.XHCI.HUB7.PRT1)
+{
+ // Left Front USB 2.0
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ Zero, // USB Port
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (One))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT2)
+{
+ // Left Rear USB 2.0
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ Zero, // USB Port
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (One))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT3)
+{
+ // Webcam
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0xFF, // OEM Connector
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Not Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (Zero))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT4)
+{
+ // Bluetooth
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0xFF, // OEM Connector
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Not Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (Zero))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.PRT7)
+{
+ // SD Card
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0xFF, // OEM Connector
+ Zero, // Reserved
+ Zero // Reserved
+ })
+
+ // Not Visible
+ Method (_PLD, 0, NotSerialized)
+ {
+ Return (GPLD (Zero))
+ }
+}
+Scope (\_SB.PCI0.XHCI.HUB7.SSP1)
+{
+ // Left USB 3.0
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0x03, // USB 3.0 Port
+ Zero, // Reserved
+ Zero // Reserved
+ })
+}
+Scope (\_SB.PCI0.XHCI.HUB7.SSP2)
+{
+ // Rear USB 3.0
+ Name (_UPC, Package (0x04)
+ {
+ 0xFF, // Connectable
+ 0x03, // USB 3.0 Port
+ Zero, // Reserved
+ Zero // Reserved
+ })
+}
--
To view, visit https://review.coreboot.org/19967
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc3b5b1161f62ac0b840380679acafeff363cf45
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Matt DeVillier <matt.devillier at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
More information about the coreboot-gerrit
mailing list