[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Remove unused PCI ID from SOC header

Subrata Banik (Code Review) gerrit at coreboot.org
Wed May 31 07:26:32 CEST 2017


Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19927 )

Change subject: soc/intel/apollolake: Remove unused PCI ID from SOC header
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19927/1/src/soc/intel/apollolake/include/soc/pci_ids.h
File src/soc/intel/apollolake/include/soc/pci_ids.h:

Line 26: #define PCI_DEVICE_ID_APOLLOLAKE_AUDIO		0x5a98		/* 00:0e.0 */
> Why isn't this whole file just removed? If you move these to the shared hea
Done


-- 
To view, visit https://review.coreboot.org/19927
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a86256641f4b877de32ca81dfdaef4e9d49334a
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list