[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945/raminit.c: Refactor tRD selection

Arthur Heymans (Code Review) gerrit at coreboot.org
Fri May 26 13:30:48 CEST 2017


Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/18354

to look at the new patch set (#15).

Change subject: nb/intel/i945/raminit.c: Refactor tRD selection
......................................................................

nb/intel/i945/raminit.c: Refactor tRD selection

Inspired by gm45 code, which sets this value the same way.

Some values for tRD on 800 and 1067MHz FSB were set wrong because the
CAS/Freq selection was wrong. CAS was often selected to low and when
fixing CAS this results in tRD being too high, due to an incorrect
lookup table which caused instability.

PASSED memtest86+ during 10h+ on 1067MHZ fsb with 667MHz ddr2, CAS 5
on GA-945GCM-S2L.

Change-Id: I8002daf25b7603131b78b01075f43fd23747dd94
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 13 insertions(+), 33 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/18354/15
-- 
To view, visit https://review.coreboot.org/18354
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8002daf25b7603131b78b01075f43fd23747dd94
Gerrit-PatchSet: 15
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list