[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19603 )

Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................


Patch Set 50:

(1 comment)

https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/include/soc/gpio_apl.h
File src/soc/intel/apollolake/include/soc/gpio_apl.h:

Line 34: 	PAD_CFG0_RXPADSTSEL_MASK | PAD_CFG0_RESET_MASK)
> What is the point of this? I didn't understand. These are the things we can
Yes and any of the bits not set here will get populated from default values. In fact, I should remove the bits that do not get set from  pad config macros. gpio_configure pad does following 
pad_conf0 = pcr_read32(comm->port, config_offset);
pad_conf0 &= ~PAD_DW0_MASK;
pcr_write32(comm->port, config_offset, pad_conf0 |
                (cfg->pad_config0 & PAD_DW0_MASK));
Same logic for pad_config1


-- 
To view, visit https://review.coreboot.org/19603
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 50
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong at intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson at intel.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93 at gmail.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes