[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Bring in delta for GLK SOC

[Hannah Williams (Code Review)]

Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19603 )

Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................


Patch Set 50:

(2 comments)

https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/Kconfig
File src/soc/intel/apollolake/Kconfig:

Line 65: 	select SOC_INTEL_COMMON_BLOCK_GPIO
> We should cut apollolake over to this in its own commit. It has nothing to 
https://review.coreboot.org/#/c/19949/


https://review.coreboot.org/#/c/19603/50/src/soc/intel/apollolake/gpio_apl.c
File src/soc/intel/apollolake/gpio_apl.c:

Line 46: 		.gpi_offset = NUM_W_GPI_REGS + NUM_SW_GPI_REGS,
> 2 * NUM_W_GPI_REGS
how is gpi_offset =  n * NUM_W_GPI_REGS ?


-- 
To view, visit https://review.coreboot.org/19603
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 50
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at gmail.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Brenton Dong <brenton.m.dong at intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson at intel.com>
Gerrit-Reviewer: Han Lim Ng <nhlhanlim93 at gmail.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes