[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel common CPU code

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/19540 )

Change subject: soc/intel/common/block: Add Intel common CPU code
......................................................................


Patch Set 11:

(5 comments)

https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/Kconfig
File src/soc/intel/common/block/cpu/Kconfig:

PS11, Line 3: 	help
set 'default n'
Also,
Common CPU code is supported for SOCs starting from SKL, KBL, APL, GLK and future.. It would good to mention it here.


https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu.c
File src/soc/intel/common/block/cpu/cpu.c:

PS11, Line 58: 	{ 0, 0 },
GLK CPUIDs?


https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu_early.c
File src/soc/intel/common/block/cpu/cpu_early.c:

PS11, Line 164:  * 7:0 -     MAX_TURBO_1_CORE
              :  * 15:8 -   MAX_TURBO_2_CORES
              :  * 23:16 - MAX_TURBO_3_CORES
              :  * 31:24 - MAX_TURBO_4_CORES
please reformat text.


https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/include/intelblocks/cpu.h
File src/soc/intel/common/block/include/intelblocks/cpu.h:

PS11, Line 36: 
GLK CPUIDs?


https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/include/intelblocks/msr.h
File src/soc/intel/common/block/include/intelblocks/msr.h:

PS11, Line 124: /* MTRR_CAP_MSR bits */
              : #define SMRR_SUPPORTED	(1<<11)
              : #define PRMRR_SUPPORTED	(1<<12)
add one more tab to align


-- 
To view, visit https://review.coreboot.org/19540
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f80c42132d9ea738be4051d2395e9e51ac153f8
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Cole Nelson <colex.nelson at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes