[coreboot-gerrit] Change in coreboot[master]: pciexp_device: Prevent race condition with retrain link

Youness Alaoui (Code Review) gerrit at coreboot.org
Thu May 25 00:07:21 CEST 2017


Hello build bot (Jenkins),

I'd like you to reexamine a change.  Please visit

    https://review.coreboot.org/19556

to look at the new patch set (#3).

Change subject: pciexp_device: Prevent race condition with retrain link
......................................................................

pciexp_device: Prevent race condition with retrain link

The PCIe specification[1] describes a race condition that
can occur when using the Retrain Link bit in the Link
Control Register.

The race condition is avoided by checking the retrain link
bit in the link status register and waiting until it is
set to 0, before initiating a new link retraining.

[1] PCI Express Base Specification Revision 3.0
    Page 633

Change-Id: I9d5840fb9a6e63838b5a4084d3bbe483f1d870ed
Signed-off-by: Youness Alaoui <youness.alaoui at puri.sm>
---
M src/device/pciexp_device.c
1 file changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/19556/3
-- 
To view, visit https://review.coreboot.org/19556
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d5840fb9a6e63838b5a4084d3bbe483f1d870ed
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list