[coreboot-gerrit] Change in coreboot[master]: pciexp_device: Prevent race condition with retrain link

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu May 4 12:07:34 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19556 )

Change subject: pciexp_device: Prevent race condition with retrain link
......................................................................


Patch Set 1:

(1 comment)

Any idea if this is PCIe 3.0 specific?

https://review.coreboot.org/#/c/19556/1/src/device/pciexp_device.c
File src/device/pciexp_device.c:

Line 56: 	/* Implementation note (page 633) in PCIe Specification 3.0 suggests
Nit: Since try needs to be initialised at the same value twice would for loops not make more sence?


-- 
To view, visit https://review.coreboot.org/19556
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d5840fb9a6e63838b5a4084d3bbe483f1d870ed
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list