[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Implement GPIO ACPI AML generating functions
Duncan Laurie (Code Review)
gerrit at coreboot.org
Tue May 23 21:45:22 CEST 2017
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/19828 )
Change subject: soc/intel/skylake: Implement GPIO ACPI AML generating functions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/19828/1/src/soc/intel/skylake/acpi.c
File src/soc/intel/skylake/acpi.c:
Line 713:
maybe delete this blank line, or add one to the above function, just so they are consistent
--
To view, visit https://review.coreboot.org/19828
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77e5d0decd8929a922d06b02312378f092551667
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-HasComments: Yes
More information about the coreboot-gerrit
mailing list