[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: [WIP]Use CPU common code

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19827 )

Change subject: soc/intel/apollolake: [WIP]Use CPU common code
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/19827/2/src/soc/intel/apollolake/Makefile.inc
File src/soc/intel/apollolake/Makefile.inc:

PS2, Line 97: CPPFLAGS_common += -I$(src)/soc/intel/apollolake
why we need this


https://review.coreboot.org/#/c/19827/2/src/soc/intel/apollolake/include/soc/cpu.h
File src/soc/intel/apollolake/include/soc/cpu.h:

PS2, Line 33: define BASE_CLOCK_MHZ		100
bclk is there at common code


PS2, Line 39: #define APL_BURST_MODE_DISABLE		0x40
already there


-- 
To view, visit https://review.coreboot.org/19827
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I529c67cf20253cf819d1c13849300788104b083c
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes