[coreboot-gerrit] Change in coreboot[master]: drivers/spi/spi-generic: Make spi_setup_slave strong symbol
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Mon May 22 23:24:09 CEST 2017
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19781 )
Change subject: drivers/spi/spi-generic: Make spi_setup_slave strong symbol
......................................................................
Patch Set 4:
> I was wondering that. We're unconditionally adding spi-generic.c to all the builds. Should we add a NO_SPI Kconfig that will help guard the spi-generic calls?
Yeah, I think we would need something like that.
--
To view, visit https://review.coreboot.org/19781
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b9bbb5303dad7ce062958a0ab8dee49a4ec1e0
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No
More information about the coreboot-gerrit
mailing list