[coreboot-gerrit] Change in coreboot[master]: drivers/spi/spi-generic: Make spi_setup_slave strong symbol

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19781 )

Change subject: drivers/spi/spi-generic: Make spi_setup_slave strong symbol
......................................................................


Patch Set 4:

Looks like there is a board which wants to use spi without support for it in the soc:

/dev/cb-build/coreboot-gerrit.0/GOOGLE_COSMOS/bootblock/drivers/spi/spi-generic.o: In function `spi_setup_slave':
/home/coreboot/slave-root/workspace/coreboot-gerrit/src/drivers/spi/spi-generic.c:139: undefined reference to `spi_ctrlr_bus_map_count'
/home/coreboot/slave-root/workspace/coreboot-gerrit/src/drivers/spi/spi-generic.c:139: undefined reference to `spi_ctrlr_bus_map'
src/arch/arm/Makefile.inc:60: recipe for target '/dev/cb-build/coreboot-gerrit.0/GOOGLE_COSMOS/cbfs/fallback/bootblock.debug' failed
make[1]: *** [/dev/cb-build/coreboot-gerrit.0/GOOGLE_COSMOS/cbfs/fallback/bootblock.debug] Error 1
make[1]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit'

-- 
To view, visit https://review.coreboot.org/19781
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59b9bbb5303dad7ce062958a0ab8dee49a4ec1e0
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No