[coreboot-gerrit] Change in coreboot[master]: src/southbridge/i82801gx: Include a default SeaBIOS config file

[Kevin O'Connor (Code Review)]

Kevin O'Connor has posted comments on this change. ( https://review.coreboot.org/19690 )

Change subject: src/southbridge/i82801gx: Include a default SeaBIOS config file
......................................................................


Patch Set 1:

> > The SeaBIOS ATA DMA setting isn't safe on PATA, nor is it safe on
 > > SATA to PATA adapters.
 > 
 > Thanks for the clarification.
 > 
 > How about a whitelist in SeaBIOS then? For the ICH7 that would be
 > DID
 > 0x27c0 and 0x27c4 if I read the spec update correctly. If we'd want
 > to be extra sure, we could check that combined mode is disabled
 > (PCI+0x90 bits 0..1 should be zero).

A whitelist would be fine, but what would we whitelist?  How would we know if a port is PATA, SATA, or PATA over SATA bridge?  It's been a while since I looked at the ATA specs, so it may be possible to do something sane.  My recollection was that enabling DMA on ATA was controller specific and thus too much of a hassle to support in SeaBIOS.

-- 
To view, visit https://review.coreboot.org/19690
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6e79ea6cd0a14070b8092aefa477b9e3a0c4b1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kevin O'Connor <kevin at koconnor.net>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No