[coreboot-gerrit] Change in coreboot[master]: src/southbridge/i82801gx: Include a default SeaBIOS config file

[Kevin O'Connor (Code Review)]

Kevin O'Connor has posted comments on this change. ( https://review.coreboot.org/19690 )

Change subject: src/southbridge/i82801gx: Include a default SeaBIOS config file
......................................................................


Patch Set 1:

> > > (1 comment)
 > > >
 > > > > Why can’t this be enabled by default for coreboot?
 > > >
 > > > Why isn't it the global default in SeaBIOS?
 > >
 > > The SeaBIOS ATA DMA setting isn't safe on PATA, nor is it safe on
 > > SATA to PATA adapters.  On those devices, a complicated
 > controller
 > > specific negotiation must be done to determine the DMA level. 
 > The
 > > SeaBIOS ATA DMA support works fine on regular SATA devices, but
 > > almost all new machines use an AHCI controller now.
 > 
 > Many boards with this southbridge do feature PATA ports, but don't
 > have ACHI for SATA...

If this southbridge has PATA ports, then I would not proceed with this patch.  The SeaBIOS DMA support is not complete on real PATA drives.

-- 
To view, visit https://review.coreboot.org/19690
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a6e79ea6cd0a14070b8092aefa477b9e3a0c4b1
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kevin O'Connor <kevin at koconnor.net>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No