[coreboot-gerrit] Change in coreboot[master]: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu May 18 06:04:07 CEST 2017


Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19757 )

Change subject: drivers/spi/flash: Move flash ops to spi_flash_ctrlr structure
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/19757/5/src/include/spi_flash.h
File src/include/spi_flash.h:

PS5, Line 37: spi_flash_ctrlr 
> Ya. It might be better named like that. However, noting that the probe func
Agreed. It will avoid lot of confusion around the use of structure and who needs to define what and how it has to be used. I will update the CLs.


-- 
To view, visit https://review.coreboot.org/19757
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I550cc4556fc4b63ebc174a7e2fde42251fe56052
Gerrit-PatchSet: 5
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list