[coreboot-gerrit] Change in coreboot[master]: Add cross-compile support for true x86 16-bit GCC (ia16)

Martin Roth (Code Review) gerrit at coreboot.org
Tue May 16 17:04:46 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/19711 )

Change subject: Add cross-compile support for true x86 16-bit GCC (ia16)
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19711/1//COMMIT_MSG
Commit Message:

PS1, Line 20: Signed-Off-By
This is typically lowercase except for the 'S' - "Signed-off-by".  I don't know if it matters, but that's why the lint test failed.

I'll fix the asm lint check now, and if we decide that the case of the signed-off-by statement doesn't matter, I'll update that too.


-- 
To view, visit https://review.coreboot.org/19711
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c2de354cae9698aa57c0b8698ce93fea001591e
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Rudolf Marek <r.marek at assembler.cz>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list