[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x: Define and use default MMCONF_BASE_ADDRESS

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu May 11 16:40:22 CEST 2017


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19650 )

Change subject: nb/intel/x4x: Define and use default MMCONF_BASE_ADDRESS
......................................................................


nb/intel/x4x: Define and use default MMCONF_BASE_ADDRESS

Currently only one board uses this northbridge in coreboot but some
patches are pending to add more.

Change-Id: If035e442d1a23674667f46a07b44c4f2b81be48c
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
Reviewed-on: https://review.coreboot.org/19650
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Nico Huber <nico.h at gmx.de>
---
M src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
M src/northbridge/intel/x4x/Kconfig
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved



diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig b/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
index ae57e5b..909e580 100644
--- a/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
+++ b/src/mainboard/gigabyte/ga-g41m-es2l/Kconfig
@@ -35,10 +35,6 @@
 	select HAVE_CMOS_DEFAULT
 	select HAVE_ACPI_RESUME
 
-config MMCONF_BASE_ADDRESS
-	hex
-	default 0xe0000000
-
 config MAINBOARD_DIR
 	string
 	default "gigabyte/ga-g41m-es2l"
diff --git a/src/northbridge/intel/x4x/Kconfig b/src/northbridge/intel/x4x/Kconfig
index 716a015..f5dd39e 100644
--- a/src/northbridge/intel/x4x/Kconfig
+++ b/src/northbridge/intel/x4x/Kconfig
@@ -38,4 +38,8 @@
 	string
 	default "8086,2e32"
 
+config MMCONF_BASE_ADDRESS
+	hex
+	default 0xe0000000
+
 endif

-- 
To view, visit https://review.coreboot.org/19650
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If035e442d1a23674667f46a07b44c4f2b81be48c
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>



More information about the coreboot-gerrit mailing list