[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Fix some errors/warnings given by checkpatch

Tristan Corrick (Code Review) gerrit at coreboot.org
Wed May 10 13:21:16 CEST 2017


Tristan Corrick has uploaded a new change for review. ( https://review.coreboot.org/19651 )

Change subject: nb/intel/gm45: Fix some errors/warnings given by checkpatch
......................................................................

nb/intel/gm45: Fix some errors/warnings given by checkpatch

This results in raminit_receive_enable_calibration.c producing
no errors or warnings with checkpatch.

The issues fixed are:
ERROR: that open brace { should be on the previous line
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Tested by compiling after making the changes.

Change-Id: I8d2f4f1fe2f17aa44c0a7090c178eee418defe78
Signed-off-by: Tristan Corrick <tristancorrick86 at gmail.com>
---
M src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/19651/1

diff --git a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
index 0d346bf..c5614e1 100644
--- a/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
+++ b/src/northbridge/intel/gm45/raminit_receive_enable_calibration.c
@@ -209,11 +209,14 @@
 	/*     F */{ { 0, 0 }, { 3, 3 }, { 6, 6 }, { 5, 5 } },
 	};
 
-	const int cardF[] =
-		{ dimms[0].card_type == 0xf, dimms[0].card_type == 0xf };
-	const unsigned t_bound =
+	const int cardF[] = {
+		dimms[0].card_type == 0xf,
+		dimms[0].card_type == 0xf,
+	};
+
+	const unsigned int t_bound =
 		(timings->mem_clock == MEM_CLOCK_1067MT) ? 9 : 12;
-	const unsigned p_bound =
+	const unsigned int p_bound =
 		(timings->mem_clock == MEM_CLOCK_1067MT) ? 8 : 1;
 
 	rec_timing_t rec_timings[2][4] = {

-- 
To view, visit https://review.coreboot.org/19651
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d2f4f1fe2f17aa44c0a7090c178eee418defe78
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Tristan Corrick <tristancorrick86 at gmail.com>



More information about the coreboot-gerrit mailing list