[coreboot-gerrit] Change in coreboot[master]: util: Add tools for dumping and inserting KBC1126 firmware i...

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19071 )

Change subject: util: Add tools for dumping and inserting KBC1126 firmware images.
......................................................................


Patch Set 3: Code-Review+2

> (1 comment)
 > 
 > > (1 comment)
 > >
 > > Some pending flashrom patches with layouts you might be able to
 > > just leave those blobs in flash with the right layout file. Still
 > > it's nice to have a tool to easily extract them.
 > 
 > The 8 bytes at $s-0x100 is always needed, so is it possible to
 > flash two segments of flash at once?

With some pending patches you could specify where stuff needs to go indeed. so with a layout you could have a list of -i region:file iirc...

-- 
To view, visit https://review.coreboot.org/19071
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic521b177b9602ff042312cccaaa89371db7c5855
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No