[coreboot-gerrit] Change in coreboot[master]: util: Add tools for dumping and inserting KBC1126 firmware i...

[Iru Cai (Code Review)]

Iru Cai has posted comments on this change. ( https://review.coreboot.org/19071 )

Change subject: util: Add tools for dumping and inserting KBC1126 firmware images.
......................................................................


Patch Set 3:

(1 comment)

> (1 comment)
 > 
 > Some pending flashrom patches with layouts you might be able to
 > just leave those blobs in flash with the right layout file. Still
 > it's nice to have a tool to easily extract them.

The 8 bytes at $s-0x100 is always needed, so is it possible to flash two segments of flash at once?

https://review.coreboot.org/#/c/19071/3/util/kbc1126/README.md
File util/kbc1126/README.md:

PS3, Line 23:   
> please get rid of those extra spaces at the end of lines of radare output.
I use markdown.pl to convert the page to HTML, so these spaces are needed.


-- 
To view, visit https://review.coreboot.org/19071
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic521b177b9602ff042312cccaaa89371db7c5855
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes