[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable PARALLEL_MP_AP_WORK

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19608 )

Change subject: soc/intel/skylake: Enable PARALLEL_MP_AP_WORK
......................................................................


Patch Set 1:

(2 comments)

> What can be done in the future to avoid such regressions?

We will have to ensure that any new major change to SoC or core infra is well-tested for basic booting, time for booting as well as good number of suspend-resume cycles to ensure there is no regression.

https://review.coreboot.org/#/c/19608/1//COMMIT_MSG
Commit Message:

PS1, Line 9: a4b11e5c90
> Please add the commit message summary in brackets after the hash.
Done.


Line 13: always failed in ramstage for Skylake / Kaby Lake mainboards.
> As the test of this commit only mentions suspend/resume cycles, did MTRR pr
Yes, I identified the issue when I observed problems with suspend-resume. I haven't seen issues in any other operation until now.


-- 
To view, visit https://review.coreboot.org/19608
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22a8f6ac90ba35075ff97dd57bab66c129f3e771
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philippe Mathieu-Daudé <philippe.mathieu.daude at gmail.com>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes