[coreboot-gerrit] Change in coreboot[master]: google/gru: support 800M/928M frequency for bob

[Caesar Wang (Code Review)]

Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19558 )

Change subject: google/gru: support 800M/928M frequency for bob
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/19558/3/src/mainboard/google/gru/sdram_configs.c
File src/mainboard/google/gru/sdram_configs.c:

Line 49: 	if (IS_ENABLED(CONFIG_BOARD_GOOGLE_BOB) && board_id() < 4)
> Rather than duplicating the file name list for all frequencies, why not jus
(1) Is that worth increasing the size to solve it?
I'm assuming that's worth.

 src/console/Makefile.inc to enable vsprintf.c in all stages, but I have seen some other build failure.
...
    CC         bootblock/lib/memchr.o
src/console/vsprintf.c:55:5: error: no previous prototype for 'snprintf' [-Werror=missing-prototypes]
 int snprintf(char *buf, size_t size, const char *fmt, ...)


Looks like, we don't need define the __PRE_RAM__ first.
index 5b2486a..34aa370 100644
--- a/src/include/string.h
+++ b/src/include/string.h
@@ -15,9 +15,9 @@ void *memmove(void *dest, const void *src, size_t n);
 void *memset(void *s, int c, size_t n);
 int memcmp(const void *s1, const void *s2, size_t n);
 void *memchr(const void *s, int c, size_t n);
+//#if !defined(__PRE_RAM__)
 int snprintf(char * buf, size_t size, const char *fmt, ...);
+//#endif


-- 
To view, visit https://review.coreboot.org/19558
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I613050292a09ff56f4636d7af285075e32259ef4
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes