[coreboot-gerrit] Change in coreboot[master]: google/gru: support 800M/928M frequency for bob

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/19558 )

Change subject: google/gru: support 800M/928M frequency for bob
......................................................................


Patch Set 4:

(3 comments)

https://review.coreboot.org/#/c/19558/3/src/mainboard/google/gru/sdram_configs.c
File src/mainboard/google/gru/sdram_configs.c:

Line 49: 	if (IS_ENABLED(CONFIG_BOARD_GOOGLE_BOB) && board_id() < 4)
> Then, can the CONFIG_GRU_SDRAM_FREQ be defined by the board_id()?
Oh, yeah, right. I forgot why we've been doing this whole thing. Sorry.


https://review.coreboot.org/#/c/19558/4/src/mainboard/google/gru/sdram_configs.c
File src/mainboard/google/gru/sdram_configs.c:

Line 49: 	if (IS_ENABLED(CONFIG_BOARD_GOOGLE_BOB) && board_id() < 4)
Okay, you were right about the Kconfig, of course (although it might still be nice to have a user-configurable Kconfig and then just do max(CONFIG_GRU_SDRAM_FREQ, 800) for the older Bob boards). But I'd still like to do this with a single table and an snprintf() instead. Just write an int get_sdram_freq(void) function and put the Bob board ID stuff in there.


https://review.coreboot.org/#/c/19558/4/src/mainboard/google/gru/sdram_params_800/Makefile.inc
File src/mainboard/google/gru/sdram_params_800/Makefile.inc:

Line 16: freq := 800
And the stuff I said about file names here still applies, too.


-- 
To view, visit https://review.coreboot.org/19558
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I613050292a09ff56f4636d7af285075e32259ef4
Gerrit-PatchSet: 4
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Caesar Wang <wxt at rock-chips.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philip Chen <philipchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: Yes