[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS

[Kevin Keijzer (Code Review)]

Kevin Keijzer has posted comments on this change. ( https://review.coreboot.org/19090 )

Change subject: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS
......................................................................


Patch Set 2: Code-Review+1

I would personally prefer the cbfs override to be present, because it seems like the easiest way to test a PWM value reliably prior to reporting the correct, tested value to be added to the whitelist. It's also a decent way to add an "unsupported" display without having to re-compile a ROM, or to work around degraded panels or weird inverters.

-- 
To view, visit https://review.coreboot.org/19090
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82e90e47ffc42b8d7062af87f6b174cd03445bb7
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Kevin Keijzer <kevin at librepractice.org>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No