[coreboot-gerrit] Change in coreboot[master]: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon May 8 22:10:30 CEST 2017


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19090 )

Change subject: nb/intel/gm45: Allow setting backlight pwm frequency from CBFS
......................................................................


Patch Set 2:

how do you feel about this one? It allows the user to finetune it without recompiling but on the other hand I feel it's over engineered a little with a general default, a devicetree default, per EDID override and now with cbfs override...

-- 
To view, visit https://review.coreboot.org/19090
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82e90e47ffc42b8d7062af87f6b174cd03445bb7
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-HasComments: No



More information about the coreboot-gerrit mailing list