[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel XDCI code support

Subrata Banik (Code Review) gerrit at coreboot.org
Wed May 3 18:25:32 CEST 2017


Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19428 )

Change subject: soc/intel/common/block: Add Intel XDCI code support
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/19428/2/src/include/device/pci_ids.h
File src/include/device/pci_ids.h:

Line 2668: #define PCI_DEVICE_ID_INTEL_GLK_XDCI 0x31aa
> You are going to start having collisions: https://review.coreboot.org/#/c/1
okay, we will create a complete device id list first


-- 
To view, visit https://review.coreboot.org/19428
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list