[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Add Intel XDCI code support

Subrata Banik (Code Review) gerrit at coreboot.org
Wed May 3 18:21:34 CEST 2017


Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19428 )

Change subject: soc/intel/common/block: Add Intel XDCI code support
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/xdci/xdci.c
File src/soc/intel/common/block/xdci/xdci.c:

Line 42: 	.devices	 = pci_device_ids,
> Or you let the SoC demultiplex the single callout. Or put a local wrapper t
i will try to implement something like that as you said, but can we address the same in next set of common code implementation phase. I'm internally tracking if we can complete all IP code by next 1-2 week. And in this process we may figure out the amount of repetition


-- 
To view, visit https://review.coreboot.org/19428
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cbc686a00c26b92be2847b6bd6c2e5aa5a690f7
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov at intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan at intel.com>
Gerrit-Reviewer: Barnali Sarkar <barnali.sarkar at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-HasComments: Yes



More information about the coreboot-gerrit mailing list